Clarify conftest hook timing before collection#14563
Closed
CortexShadow wants to merge 1 commit into
Closed
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Member
|
Thanks, but we already have a note to this effect a bit below ("Some hooks cannot be implemented in conftest.py files [...]"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify that only initial conftest files are available for hooks which run before collection, such as
pytest_sessionstartandpytest_report_header.This addresses the confusing case where a deeper conftest can still receive later/historic hooks like
pytest_configure, but cannot affect the terminal header oncepytest_report_headerhas already run.Closes #14557.